Remove TF1-based examples (eva.py, exploitability_descent.py)#1455
Conversation
These examples depend on TensorFlow 1.x which is deprecated. A PyTorch version of EVA exists at open_spiel/python/pytorch/eva.py. Per maintainer guidance in google-deepmind#1434, TF1-based examples should be removed in preparation for OpenSpiel 2.0. Closes google-deepmind#1434 (partial)
|
why only these two.... |
Agreed. Probably time to drop this whole directory: https://github.com/google-deepmind/open_spiel/tree/master/open_spiel/python/algorithms/tf Can we add it to this PR? |
|
yes, let's get rid of that. I won't back to then, need to get rid of and https://github.com/google-deepmind/open_spiel/blob/master/open_spiel/scripts/find_tensorflow.sh I guess that's it! you may feel sceptical about that, because some components related to |
|
Oh yes, good point!
I do believe |
|
Yes, let's try, I tried to remove those deps wherever I could. But still could miss smth. |
|
@lanctot, I will aslo need to delete some other tensorflow things that don't break the tests but stay redundant because they were need to be compatible with |
|
Got it! Since @alexunderch was already working on the broader TF cleanup and refactoring, I'll leave the |
Summary
Removes TF1-based examples from the
open_spiel/python/examples/directory as requested by @lanctot in #1434.Changes
eva.py- usestensorflow.compat.v1exploitability_descent.py- usestf.disable_v2_behavior()Rationale
Per maintainer guidance in #1434:
A PyTorch version of EVA exists at
open_spiel/python/pytorch/eva.py, so the TF1 example removal is safe.Verification
Addresses #1434 (partial)