Skip to content

Add TGLFBasedTransportModel#1417

Merged
copybara-service[bot] merged 1 commit intomainfrom
tglf-based-transport-models
Sep 8, 2025
Merged

Add TGLFBasedTransportModel#1417
copybara-service[bot] merged 1 commit intomainfrom
tglf-based-transport-models

Conversation

@theo-brown
Copy link
Collaborator

@theo-brown theo-brown commented Aug 6, 2025

Pulling out the good bits of #477 and bringing them up to date.

Aim for this PR is to focus on implementing the convertor between TORAX outputs and TGLF inputs. Other parts of #477 are being divided up, as more people are getting involved in working on it.

@theo-brown theo-brown force-pushed the tglf-based-transport-models branch 8 times, most recently from c16d517 to 4cfdeff Compare August 8, 2025 12:54
@theo-brown
Copy link
Collaborator Author

theo-brown commented Aug 8, 2025

Input conversion validated against JETTO TGLF runs for a spherical tokamak test case, using the EQDSK and IMAS equilibrium IDS from JETTO as the input to TORAX.
image(2)
image(1)

@theo-brown theo-brown force-pushed the tglf-based-transport-models branch from ac033c0 to a18e0cf Compare August 8, 2025 19:17
@theo-brown
Copy link
Collaborator Author

Thanks for taking a look at this @Nush395, I moved a bunch of stuff to the docstring as suggested.

@theo-brown theo-brown force-pushed the tglf-based-transport-models branch from ec704ce to 9de51d7 Compare August 11, 2025 17:00
@theo-brown theo-brown force-pushed the tglf-based-transport-models branch 2 times, most recently from 60cc621 to 03cae96 Compare August 13, 2025 19:17
@jcitrin
Copy link
Collaborator

jcitrin commented Aug 14, 2025

FYI @gsnoep , @aaronkho

@theo-brown theo-brown force-pushed the tglf-based-transport-models branch from 03cae96 to 19f3ea0 Compare August 15, 2025 10:37
@theo-brown theo-brown requested a review from jcitrin August 15, 2025 10:38
@jcitrin jcitrin added the copybara:import-manual Set when ready for copybara manual import label Aug 16, 2025
@theo-brown
Copy link
Collaborator Author

@jcitrin sorry I noticed some things that still needed doing. Is it ok for me to push to this branch now that you've marked it as copybara:import-manual, or is there a better option?

@jcitrin
Copy link
Collaborator

jcitrin commented Aug 18, 2025

@theo-brown , sure go ahead and add. We hadn't actually started the internal review yet, no worries. Will hold off on it.

@jcitrin jcitrin removed the copybara:import-manual Set when ready for copybara manual import label Aug 18, 2025
@theo-brown
Copy link
Collaborator Author

Thanks! I'm working on #1436 and this in parallel, having validated that the TGLFNNukaea implemented in fusion_surrogates is correctly reproducing the fluxes from the tglfnn-ukaea repo. Some issues I find are to do with how I'm talking to the NN, and some are with how I'm generating inputs/outputs, so there's a bit of bouncing between the two issues as I iterate. Hopefully should be able to get this in this week?

@theo-brown theo-brown force-pushed the tglf-based-transport-models branch 3 times, most recently from 70b738e to 7d61388 Compare August 21, 2025 20:34
@theo-brown theo-brown requested a review from jcitrin August 21, 2025 20:35
@theo-brown theo-brown force-pushed the tglf-based-transport-models branch from 7d61388 to f910b24 Compare September 2, 2025 10:57
* Add TGLFInputs for converting from TORAX to TGLF

Future PRs will add TGLF surrogates and an interface with TGLF
@theo-brown theo-brown force-pushed the tglf-based-transport-models branch from f910b24 to 14b6603 Compare September 2, 2025 11:40
@theo-brown
Copy link
Collaborator Author

Summary of changes since last review:

  • Rebased onto main, removed DynamicRuntime objects
  • Updated links to GACODE docs

@theo-brown theo-brown requested a review from Nush395 September 2, 2025 11:41
@theo-brown
Copy link
Collaborator Author

theo-brown commented Sep 2, 2025

@jcitrin this is ready for a re-review / for the copybara-import-manual label to be added back!

@jcitrin jcitrin added the copybara:import-manual Set when ready for copybara manual import label Sep 5, 2025
@copybara-service copybara-service bot merged commit ae23a30 into main Sep 8, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copybara:import-manual Set when ready for copybara manual import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants