Add TGLFBasedTransportModel#1417
Conversation
c16d517 to
4cfdeff
Compare
ac033c0 to
a18e0cf
Compare
|
Thanks for taking a look at this @Nush395, I moved a bunch of stuff to the docstring as suggested. |
ec704ce to
9de51d7
Compare
60cc621 to
03cae96
Compare
03cae96 to
19f3ea0
Compare
|
@jcitrin sorry I noticed some things that still needed doing. Is it ok for me to push to this branch now that you've marked it as |
|
@theo-brown , sure go ahead and add. We hadn't actually started the internal review yet, no worries. Will hold off on it. |
|
Thanks! I'm working on #1436 and this in parallel, having validated that the TGLFNNukaea implemented in fusion_surrogates is correctly reproducing the fluxes from the tglfnn-ukaea repo. Some issues I find are to do with how I'm talking to the NN, and some are with how I'm generating inputs/outputs, so there's a bit of bouncing between the two issues as I iterate. Hopefully should be able to get this in this week? |
70b738e to
7d61388
Compare
7d61388 to
f910b24
Compare
* Add TGLFInputs for converting from TORAX to TGLF Future PRs will add TGLF surrogates and an interface with TGLF
f910b24 to
14b6603
Compare
|
Summary of changes since last review:
|
|
@jcitrin this is ready for a re-review / for the copybara-import-manual label to be added back! |


Pulling out the good bits of #477 and bringing them up to date.
Aim for this PR is to focus on implementing the convertor between TORAX outputs and TGLF inputs. Other parts of #477 are being divided up, as more people are getting involved in working on it.