Change expected_impurities to excluded_impurities in plasma_composition_from_IMAS #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateoBell
changed the title
MateoBell
added
the
ready for review
This was referenced Dec 7, 2025
jcitrin
approved these changes
Dec 7, 2025
Collaborator
|
@Nush395 could you also review this one please? |
Nush395
reviewed
Dec 8, 2025
MateoBell
force-pushed
the
update_imas_plasma_composition_parsing
branch
from
ebae3bf to
e9458b8
Compare
MateoBell
force-pushed
the
update_imas_plasma_composition_parsing
branch
2 times, most recently
from
e94622d to
d61a1c8
Compare
Nush395
reviewed
Dec 20, 2025
MateoBell
force-pushed
the
update_imas_plasma_composition_parsing
branch
from
d61a1c8 to
f2181d3
Compare
Collaborator
Author
|
@Nush395 : Should these new functions go into |
Collaborator
Sorry for the slow reply. I think moving into |
Closes IMAS plasma composition surprising behaviour #1789 Parse all ions by default to avoid ignoring ions without the user knowing Update imas sim_test example correctly parse ions Slight change of error message Add comment for str(ion) cast Change default main_ion_symbols to None separate function to validate main_ions presence
MateoBell
force-pushed
the
update_imas_plasma_composition_parsing
branch
from
f2181d3 to
f7ff91a
Compare
Collaborator
Author
|
Ok I moved the files and add small unit tests now they are in separate module ! Also rebased onto main and semi-squashed it. Let me know if there is still any change to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1789
Parse all ions by default to avoid ignoring ions without the user knowing.
Changes:
expected_impuritiestoexcluded_impuritiesarg. Now parse all ions in the IDS except those inexcluded_impurities._validate_ids_ionshelper function to validate that all parsed ions have recognized TORAX symbols and raise informative error if not