Skip to content

Conversation

@MateoBell
Copy link
Collaborator

New imas-python 2.1.0 release disabled implicit conversion between major DD versions #82 which broke imas loader test (change from warning to RuntimeError).

Updated imas-python requirement and fixed the test.

@MateoBell MateoBell added bug Something isn't working ready for review Add to PRs when they are ready for review unsure of who to assign as reviewer labels Dec 12, 2025
Copy link
Collaborator

@Nush395 Nush395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1.0 isn't released from what I can tell at https://github.com/iterorganization/IMAS-Python. Is this a private version that you are using?

@MateoBell
Copy link
Collaborator Author

I think there is just this tag for now https://github.com/iterorganization/IMAS-Python/releases/tag/2.1.0-post1. It triggered a version change for the version use in the pipeline I guess, gave failures when I committed on #1630

@Nush395
Copy link
Collaborator

Nush395 commented Dec 15, 2025

Ah interesting, we need to import the library but I think there is a small issue with the release that prevents our tests from running without imas-core that I've raised iterorganization/IMAS-Python#88.

For now I'm proposing restricting to use 2.0.1, is that suitable for your use case?

@MateoBell
Copy link
Collaborator Author

Yes it perfectly fine for me I think every feature should work fine with 2.0.1 for now !
I was thinking about restricting it to 2.0.1 as well to fix the issue, and can upgrade once this issue is fixed.

@Nush395
Copy link
Collaborator

Nush395 commented Dec 15, 2025

Yes it perfectly fine for me I think every feature should work fine with 2.0.1 for now ! I was thinking about restricting it to 2.0.1 as well to fix the issue, and can upgrade once this issue is fixed.

Awesome, thanks Mateo :)

@Nush395
Copy link
Collaborator

Nush395 commented Jan 8, 2026

Hey Mateo, sorry for the wait on this. Just an update, we're looking to add imas_core to our deps so should be able to bring this in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready for review Add to PRs when they are ready for review unsure of who to assign as reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants