-
Notifications
You must be signed in to change notification settings - Fork 106
Fix imas loader test due to new imas-python tag #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.1.0 isn't released from what I can tell at https://github.com/iterorganization/IMAS-Python. Is this a private version that you are using?
|
I think there is just this tag for now https://github.com/iterorganization/IMAS-Python/releases/tag/2.1.0-post1. It triggered a version change for the version use in the pipeline I guess, gave failures when I committed on #1630 |
|
Ah interesting, we need to import the library but I think there is a small issue with the release that prevents our tests from running without imas-core that I've raised iterorganization/IMAS-Python#88. For now I'm proposing restricting to use 2.0.1, is that suitable for your use case? |
|
Yes it perfectly fine for me I think every feature should work fine with 2.0.1 for now ! |
Awesome, thanks Mateo :) |
|
Hey Mateo, sorry for the wait on this. Just an update, we're looking to add imas_core to our deps so should be able to bring this in soon. |
New imas-python 2.1.0 release disabled implicit conversion between major DD versions #82 which broke imas loader test (change from warning to RuntimeError).
Updated imas-python requirement and fixed the test.