Improve numerics of saturation and formation models.#2036
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 6, 2026
Merged
Improve numerics of saturation and formation models.#2036copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_878555972
branch
6 times, most recently
from
23c0d9a to
4905765
Compare
- Switch the formation model to use linear interpolation between base_multiplier and 1.0 based on sigmoid(P_sol - P_LH) - Switch the saturation model to use softplus, giving linear increase in transport: (value_at_ped_top - desired_value_at_ped_top) * base_multiplier - Ensure clipping is only applied to the final transport multipliers, rather than components - Update names of model parameters for improved interpretability These changes made the solver converge noticeably faster. PiperOrigin-RevId: 879606136
copybara-service
bot
force-pushed
the
test_878555972
branch
from
4905765 to
6fac75d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve numerics of saturation and formation models.
These changes made the solver converge noticeably faster.