-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add Cost Estimation and Health Monitoring Example #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Cost Estimation and Health Monitoring Example #1088
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello @haripriyarao26, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive example for integrating cost estimation and health monitoring into Gemini API applications. It provides a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a valuable example notebook for cost estimation and health monitoring with the Gemini API. The GeminiObservability class is a well-structured and reusable component. I have a few suggestions to align the notebook with the repository's style guide and improve the code. Specifically, the new notebook should be added to examples/README.md, and its outputs should be saved as per the style guide. There are also opportunities to improve the code by adding missing type hints, using more specific exception handling, and avoiding redundant calculations.
|
Just following up on this PR! I've implemented a Cost Observability & Health Utility that standardizes USD cost estimation and integration health checks directly from usage_metadata. I’ve ensured the code is clean and follows the cookbook's standards. I'd love to get this merged to help other SDEs building cost-sensitive apps. |
Fixes #1087
Key Features: