Draft
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
It's still pretty rough, but it gets the notebooks run. Some notebooks only run with api_key, others only with oauth. We'll need to fix this. We should probably look at using colab's docker: https://twitter.com/GoogleColab/status/1663594080436375558 Then run in GH actions or kokoro. https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action |
Collaborator
|
I think we should close this PR as it's quite old and some much has changed since then... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a starter script for testing notebooks.
based on google3/devsite/tools/tensorflow/kokoro/tf_ecosystem/executor.py
This gets most notebooks passing, we can use it as a base to setup presubmits.
Some notebooks are still failing:
See also: google/generative-ai-docs#445