Skip to content

Added optional support for callbacks on streamed response #322 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abhoy21
Copy link

@abhoy21 abhoy21 commented Mar 15, 2025

Related to #322

This PR implements callbacks for streamed responses to improve developer experience. Developers can now easily manage streamed chat responses with callbacks for data chunks, completion, and error handling.

Key changes:

  • Added onData, onEnd, and onError callback options to streamed response methods
  • Updated type definitions in requests.ts to support the new callback interface
  • Modified stream-reader.ts to properly handle the callback pipeline
  • Updated relevant model implementations to support the callback pattern

Copy link

google-cla bot commented Mar 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Annhiluc Annhiluc added type:feature request New feature request/enhancement status:triaged Issue/PR triaged to the corresponding sub-team p3 labels Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 status:triaged Issue/PR triaged to the corresponding sub-team type:feature request New feature request/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants