Added an error message to nudge folks to the new SDK. #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
reviewed
Apr 12, 2025
| > ([github](https://github.com/googleapis/js-genai/tree/main)), is currently | ||
| > available in a *preview launch* - designed to work with Gemini 2.0 features | ||
| > and support both the Gemini API and the Vertex API. | ||
| > **IMPORTANT:** This SDK is intended for use with older Gemini models (e.g., Gemini 1.0 Pro, Gemini 1.5 Pro). For access to the latest models, including Gemini 2.0 and Gemini 2.5 Pro, please use the newer SDK available at [https://github.com/googleapis/js-genai](https://github.com/googleapis/js-genai). |
There was a problem hiding this comment.
We can use a much stronger message similar to the Python package, see https://github.com/google-gemini/deprecated-generative-ai-python.
For older models, we want to encourage people to use the new SDK. This SDK will be around not to break the existing users. New comers to the old models should also use the new SDK ;)
pamorgan
previously approved these changes
Apr 12, 2025
pamorgan
requested changes
Apr 14, 2025
hkt74
reviewed
Apr 28, 2025
|
|
||
| let finalMessage = `Error fetching from ${url.toString()}: [${response.status} ${response.statusText}] ${originalMessage || 'Server responded with an error.'}`; // Provide default if message is empty | ||
|
|
||
| if (isUnsupportedModelError) { |
There was a problem hiding this comment.
this might be a breaking change if user has client side logic to process the error message. Maybe a safer approach is to log a warning message to the console?
Annhiluc
added
the
status: awaiting user response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated the README. :)