Skip to content

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented Sep 25, 2024

Fixes: #559

Change-Id: I55f8339aea7e71e0b073c1a2ef9b3748500e09ed
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Sep 25, 2024
@thesofakillers
Copy link

instead of removing, shouldnt we be replacing finish_message with finish_reason as suggested by the error message?

@MarkDaoust
Copy link
Collaborator Author

Yes, but it looks like that's solved on line 474.

@shilpakancharla shilpakancharla merged commit be00c19 into google-gemini:main Sep 26, 2024
10 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown field for Candidate: finish_message
3 participants