Skip to content

Conversation

drona-gyawali
Copy link

@drona-gyawali drona-gyawali commented Mar 7, 2025

Description of the change

PR introduces support for setting per-request metadata/headers in GenerativeModel.generate_content. Previously, headers could only be set at the client configuration level using default_metadata, making it difficult to specify user-specific headers dynamically for each request. This enhancement improves flexibility, particularly for integrations with proxy services like Helicone that require user-specific headers.

Technical

Added a new parameter extra_headers: dict[str, str] | None .

Ensured that extra_headers are properly merged with existing request metadata.

Preserved backward compatibility by making extra_headers optional.

Updated function documentation to reflect the new parameter.

closes #698

Copy link

google-cla bot commented Mar 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Mar 7, 2025
@drona-gyawali drona-gyawali changed the title Feature/Add support for per-request metadata/headers #698 Feature/Add support for per-request metadata/headers Mar 8, 2025
@drona-gyawali
Copy link
Author

@chitalian, I manually checked this feature and it works. As of now, I haven't implemented any test cases because I want you to review it first. If the feature makes sense and receives your approval, I will create test cases with your permission. Thank you!

@chitalian
Copy link

Looks good @drona-gyawali ! Thanks for making this fix

@Annhiluc Annhiluc added type:feature request New feature request/enhancement status:triaged Issue/PR triaged to the corresponding sub-team p3 labels Mar 27, 2025
@drona-gyawali drona-gyawali closed this by deleting the head repository May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK p3 status:awaiting review PR awaiting review from a maintainer status:triaged Issue/PR triaged to the corresponding sub-team type:feature request New feature request/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for per-request metadata/headers in GenerativeModel.generate_content
3 participants