Skip to content

Conversation

@chouzz
Copy link

@chouzz chouzz commented Nov 22, 2025

Summary

  • make the ripgrep result cap configurable via tools.ripgrep.maxMatches
  • plumb the setting through the CLI config, core config, and ripgrep tool
  • document the new setting and add tests

Fixes #13585

@chouzz chouzz requested a review from a team as a code owner November 22, 2025 15:30
@google-cla
Copy link

google-cla bot commented Nov 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chouzz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option that allows users to control the maximum number of search results returned by the ripgrep tool. This enhancement provides greater flexibility for users to manage the volume of search output, which can be particularly useful in large repositories or when optimizing for context conservation.

Highlights

  • Configurable Ripgrep Match Limit: The maximum number of matches returned by the ripgrep tool is now configurable via the tools.ripgrep.maxMatches setting.
  • Configuration Plumbing: The new maxMatches setting has been integrated across the CLI configuration, core configuration, and the ripgrep tool's implementation.
  • Documentation and Testing: The new setting is fully documented in the CLI settings and configuration guides, and comprehensive tests have been added to ensure its correct functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration setting tools.ripgrep.maxMatches to control the maximum number of matches returned by ripgrep. The changes are well-implemented across documentation, configuration schemas, and core logic, including tests for the new functionality. I have one suggestion to improve code quality and maintainability by removing defensive coding that was likely added to accommodate incomplete test mocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ripgrep match cap configurable via settings.schema.json

1 participant