Skip to content

fix: cache extension enablement config to prevent error spam #13674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −5
Open

fix: cache extension enablement config to prevent error spam #13674

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94c52e5
fix: cache extension enablement config to prevent error spam
jduncan-rva Nov 22, 2025
fd662f1
Merge branch 'main' into fix/extension-enablement-caching
jduncan-rva Nov 24, 2025
151dc7d
Merge branch 'main' into fix/extension-enablement-caching
jduncan-rva Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions packages/cli/src/config/extensions/extensionEnablement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export class ExtensionEnablementManager {
// If non-empty, this overrides all other extension configuration and enables
// only the ones in this list.
private enabledExtensionNamesOverride: string[];
private cachedConfig: AllExtensionsEnablementConfig | undefined;

constructor(enabledExtensionNames?: string[]) {
this.configDir = ExtensionStorage.getUserExtensionsDir();
Expand Down Expand Up @@ -177,29 +178,37 @@ export class ExtensionEnablementManager {
}

readConfig(): AllExtensionsEnablementConfig {
if (this.cachedConfig) {
return this.cachedConfig;
}

try {
const content = fs.readFileSync(this.configFilePath, 'utf-8');
return JSON.parse(content);
this.cachedConfig = JSON.parse(content);
return this.cachedConfig!;
} catch (error) {
if (
error instanceof Error &&
'code' in error &&
error.code === 'ENOENT'
(error as { code: string }).code === 'ENOENT'
) {
return {};
this.cachedConfig = {};
return this.cachedConfig;
}
coreEvents.emitFeedback(
'error',
'Failed to read extension enablement config.',
`Failed to read extension enablement config at ${this.configFilePath}.`,
error,
);
return {};
this.cachedConfig = {};
return this.cachedConfig;
}
Comment on lines 189 to 205
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The catch block can be refactored to be more concise and to better align with the PR's goal of improving error reporting for syntax errors. The current implementation contains duplicated code for caching an empty configuration and uses a generic error message for parsing failures.

By restructuring this block, we can:

  1. Eliminate code duplication for caching an empty config (this.cachedConfig = {}).
  2. Provide a more specific and helpful error message when JSON.parse fails due to a SyntaxError.
  3. Consistently cache an empty config on any read failure to prevent error spam, while selectively logging errors (i.e., not logging for a missing file, which is an expected condition).
Suggested change
} catch (error) {
if (
error instanceof Error &&
'code' in error &&
error.code === 'ENOENT'
(error as { code: string }).code === 'ENOENT'
) {
return {};
this.cachedConfig = {};
return this.cachedConfig;
}
coreEvents.emitFeedback(
'error',
'Failed to read extension enablement config.',
`Failed to read extension enablement config at ${this.configFilePath}.`,
error,
);
return {};
this.cachedConfig = {};
return this.cachedConfig;
}
} catch (error) {
const isEnoent =
error instanceof Error &&
'code' in error &&
(error as { code: string }).code === 'ENOENT';
if (!isEnoent) {
let message = `Failed to read or parse extension enablement config at ${this.configFilePath}.`;
if (error instanceof SyntaxError) {
message += `\nDetails: ${error.message}`;
}
coreEvents.emitFeedback('error', message, error);
}
this.cachedConfig = {};
return this.cachedConfig;
}

}

writeConfig(config: AllExtensionsEnablementConfig): void {
fs.mkdirSync(this.configDir, { recursive: true });
fs.writeFileSync(this.configFilePath, JSON.stringify(config, null, 2));
this.cachedConfig = config;
}

enable(
Expand Down