Fix TypeError: "URL.parse is not a function" for Node.js < v22

[macarronesc]

Fixes #13615

Summary

Replaces the usage of the static method URL.parse() with the standard new URL() constructor (wrapped in a try-catch block). This change fixes the TypeError: URL.parse is not a function crash on Node.js LTS versions (v18, v20).

Details

The codebase was using URL.parse(), a static method that was only recently added to the global URL object in Node.js v22. Consequently, users running the CLI on current LTS versions (like Node.js v20) experienced immediate crashes when this code path was executed.

While other parts of the project might have been updated or patched in later versions to support broader compatibility, this specific instance in src/modules/extensions/github_download.ts (inside tryParseGithubUrl) remained unchanged, causing the persistent error reported in the issue.

The fix involves replacing:

const parsedUrl = URL.parse(source, 'https://github.com');

With the standard, backward-compatible approach:

let parsedUrl: URL;
try {
  parsedUrl = new URL(source, 'https://github.com');
} catch (error) {
  // Error handling logic matches the previous flow
}

Related Issues

Fixes #13615

How to Validate

1. Ensure you are using Node.js v20 (or any version below v22).
2. Checkout this branch and install dependencies.
3. Run the CLI (or try to install/parse a GitHub extension URL).
4. Expected Result: The CLI should execute without throwing TypeError: URL.parse is not a function.
5. Previous Result: The CLI crashed immediately upon reaching the URL parsing logic.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @macarronesc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical compatibility issue that caused the CLI to crash on Node.js LTS versions (v18 and v20). By updating the URL parsing logic to use a more widely supported and backward-compatible constructor, the application can now run without errors for users on these older Node.js environments.

Highlights

• Node.js Compatibility Fix: Replaced the static method URL.parse() with the standard new URL() constructor, wrapped in a try-catch block, to resolve a TypeError on Node.js versions older than v22 (specifically v18 and v20 LTS).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a TypeError on older Node.js versions by replacing the non-standard URL.parse() with the new URL() constructor. My review includes one high-severity comment to improve the implementation. The main point is to preserve the function's error contract by continuing to throw a TypeError for invalid URLs, avoiding a potential breaking change. The suggested change also simplifies the code logic.

[SandyTao520]

Thanks for fixing!