Skip to content

Conversation

@afarber
Copy link
Contributor

@afarber afarber commented Nov 28, 2025

Summary

Fixes 2 npm audit security vulnerabilities in transitive dependencies:

  • HIGH severity: glob command injection vulnerability (CVSS 7.5)
  • MODERATE severity: body-parser DoS vulnerability (CVSS 5.3)

Running npm audit now reports 0 vulnerabilities.

Details

Updated transitive dependencies to patched versions via npm audit fix:

Only package-lock.json modified for dependency updates. The NOTICES.txt file was auto-regenerated to reflect updated
license information for raw-body.

Related Issues

Fixes #14089

How to Validate

  npm audit # Expected: "found 0 vulnerabilities"

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@afarber afarber requested review from a team as code owners November 28, 2025 14:35
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @afarber, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's security by patching critical vulnerabilities found in key transitive dependencies. By updating 'glob' and 'body-parser' to their latest secure versions, the PR ensures that the application is protected against known exploits, maintaining a robust and secure development environment.

Highlights

  • Security Vulnerability Fixes: This pull request addresses and resolves two npm audit security vulnerabilities: a HIGH severity command injection vulnerability in the 'glob' package (CVSS 7.5) and a MODERATE severity Denial-of-Service (DoS) vulnerability in 'body-parser' (CVSS 5.3).
  • Dependency Updates: The 'glob' package has been updated from version 10.4.5 to 10.5.0, and 'body-parser' has been updated from 2.2.0 to 2.2.1. Additionally, 'raw-body', a transitive dependency of 'body-parser', was updated from 3.0.0 to 3.0.2.
  • Clean Audit Report: After these updates, running 'npm audit' now reports zero vulnerabilities, significantly improving the project's security posture.
  • File Changes: The changes primarily involve updates to 'package-lock.json' to reflect the new dependency versions and an auto-regenerated 'NOTICES.txt' file to update license information for 'raw-body'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses two security vulnerabilities reported by npm audit by updating transitive dependencies. The changes correctly update glob to version 10.5.0 and body-parser to 2.2.1, which are the patched versions for the respective vulnerabilities. The modifications in package-lock.json are consistent with the output of npm audit fix and include some formatting changes like adding peer: true to several dependencies, which is expected with newer npm versions. The NOTICES.txt file has also been correctly updated to reflect the new version of raw-body. The pull request effectively resolves the security issues and is good to merge.

@afarber afarber force-pushed the update-glob-and-body-parser branch from 7b4dc77 to 2fced6a Compare December 2, 2025 07:48
@galz10 galz10 enabled auto-merge December 2, 2025 19:48
@galz10 galz10 added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@afarber afarber force-pushed the update-glob-and-body-parser branch from 59e57b0 to f951bdd Compare December 3, 2025 13:26
@afarber
Copy link
Contributor Author

afarber commented Dec 3, 2025

Hi @galz10 @bdmorgan, I've rebased onto main - could you please approve the workflow runs? Thanks!

@jackwotherspoon
Copy link
Collaborator

Got you covered @afarber 🫡

Workflows running now

@jackwotherspoon jackwotherspoon added this pull request to the merge queue Dec 3, 2025
Merged via the queue into google-gemini:main with commit 54c62d5 Dec 3, 2025
27 checks passed
@afarber afarber deleted the update-glob-and-body-parser branch December 3, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: Fix npm audit vulnerabilities (glob and body-parser)

3 participants