-
Notifications
You must be signed in to change notification settings - Fork 9.8k
fix(security): Fix npm audit vulnerabilities in glob and body-parser #14090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(security): Fix npm audit vulnerabilities in glob and body-parser #14090
Conversation
Summary of ChangesHello @afarber, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's security by patching critical vulnerabilities found in key transitive dependencies. By updating 'glob' and 'body-parser' to their latest secure versions, the PR ensures that the application is protected against known exploits, maintaining a robust and secure development environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses two security vulnerabilities reported by npm audit by updating transitive dependencies. The changes correctly update glob to version 10.5.0 and body-parser to 2.2.1, which are the patched versions for the respective vulnerabilities. The modifications in package-lock.json are consistent with the output of npm audit fix and include some formatting changes like adding peer: true to several dependencies, which is expected with newer npm versions. The NOTICES.txt file has also been correctly updated to reflect the new version of raw-body. The pull request effectively resolves the security issues and is good to merge.
7b4dc77 to
2fced6a
Compare
…14090) Co-authored-by: Gal Zahavi <[email protected]>
59e57b0 to
f951bdd
Compare
|
Got you covered @afarber 🫡 Workflows running now |
Summary
Fixes 2 npm audit security vulnerabilities in transitive dependencies:
Running
npm auditnow reports 0 vulnerabilities.Details
Updated transitive dependencies to patched versions via
npm audit fix:glob: 10.4.5 → 10.5.0 (fixes GHSA-5j98-mcp5-4vw2)body-parser: 2.2.0 → 2.2.1 (fixes GHSA-wqch-xfxh-vrr4)raw-body: 3.0.0 → 3.0.2 (dependency of body-parser)Only
package-lock.jsonmodified for dependency updates. TheNOTICES.txtfile was auto-regenerated to reflect updatedlicense information for raw-body.
Related Issues
Fixes #14089
How to Validate
npm audit # Expected: "found 0 vulnerabilities"Pre-Merge Checklist