-
Notifications
You must be signed in to change notification settings - Fork 10.5k
fix(patch): cherry-pick ee6556c to release/v0.21.0-preview.1-pr-14691 to patch version v0.21.0-preview.1 and create version 0.21.0-preview.2 #14908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(patch): cherry-pick ee6556c to release/v0.21.0-preview.1-pr-14691 to patch version v0.21.0-preview.1 and create version 0.21.0-preview.2 #14908
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines and enhances the chat session summary generation process within the CLI. By shifting summary creation to a background task on application startup and implementing more sophisticated logic for identifying eligible sessions, it aims to improve the user experience by ensuring summaries are generated efficiently and reliably without blocking application flow. The changes also involve a move to direct file system management for session data and include an authentication refresh step to support summary generation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the session summary generation logic. Instead of generating a summary on application exit, it now generates a summary for the previous session on startup, running as a background, fire-and-forget task. This is a good improvement for user experience, as it avoids a delay on exit. The related changes across the CLI and core packages correctly support this new behavior. My review identifies one high severity issue: a race condition in the summary generation that could lead to redundant and costly LLM API calls if multiple CLI instances are started in quick succession. I've provided a code suggestion to resolve this using a file-based locking mechanism.
|
Size Change: +2.97 kB (+0.01%) Total Size: 21.6 MB
ℹ️ View Unchanged
|
d9e7933
into
release/v0.21.0-preview.1-pr-14691
This PR automatically cherry-picks commit ee6556c to patch version v0.21.0-preview.1 in the preview release to create version 0.21.0-preview.2.