Skip to content

Conversation

@sehoon38
Copy link
Collaborator

@sehoon38 sehoon38 commented Dec 16, 2025

Summary

Use previewFeatures to pick which pro model to use for A2A.

Details

A2A currently doesn't use Gemini 3 model, and this exposes a way to pick either Gemini 3 pro or Gemini 2.5 pro model depending on the previewFeatures settings.

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@sehoon38 sehoon38 requested a review from a team as a code owner December 16, 2025 03:05
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mechanism to control which Gemini Pro model is utilized by the A2A system. By leveraging the previewFeatures setting, the system can now switch between different Gemini Pro versions, enabling early access to newer models for A2A functionalities. This change allows for more flexible model deployment and testing within the A2A framework.

Highlights

  • Dynamic Gemini Model Selection: The A2A system will now dynamically select the Gemini Pro model based on the previewFeatures setting. If previewFeatures is enabled, PREVIEW_GEMINI_MODEL (Gemini 3 Pro) will be used; otherwise, DEFAULT_GEMINI_MODEL (Gemini 2.5 Pro) will be used.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

Size Change: -2 B (0%)

Total Size: 21.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 21.6 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the A2A server configuration to select the Gemini model based on the previewFeatures setting. The implementation correctly uses the setting from the configuration file. However, I've identified a potential issue where previewFeatures enabled remotely via experiments after authentication would not be respected for model selection. I've left a comment with a suggestion to fix this by re-evaluating the model after authentication is refreshed. This will ensure the logic is robust and respects both local and remote configurations.

@sehoon38 sehoon38 added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit 2995af6 Dec 16, 2025
20 checks passed
@sehoon38 sehoon38 deleted the sehoon/a2a branch December 16, 2025 04:07
@scidomino
Copy link
Collaborator

/patch preview

@github-actions
Copy link

Patch workflow(s) dispatched successfully!

📋 Details:

  • Channels: preview
  • Commit: 2995af6a21c68147823aec0587cb19330a9aeee8
  • Workflows Created: 1

🔗 Track Progress:

@github-actions
Copy link

🚀 Patch PR Created!

📋 Patch Details:

📝 Next Steps:

  1. Review and approve the hotfix PR: #15153
  2. Once merged, the patch release will automatically trigger
  3. You'll receive updates here when the release completes

🔗 Track Progress:

@github-actions
Copy link

🚀 Patch Release Started!

📋 Release Details:

  • Environment: prod
  • Channel: preview → publishing to npm tag preview
  • Version: v0.21.0-preview.5
  • Hotfix PR: Merged ✅
  • Release Branch: release/v0.21.0-preview.5-pr-15131

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

@github-actions
Copy link

Patch Release Complete!

📦 Release Details:

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

🔗 Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants