Respect previewFeatures value from the remote flag if undefined #15214

sehoon38 · 2025-12-17T20:42:20Z

Summary

Respect previewFeatures value from the remote flag if user has not set it before.

Details

To make some users automatically opt-in to use previewfeatures such as Gemini 3.

Related Issues

https://github.com/google-gemini/maintainers-gemini-cli/issues/1151

Pre-Merge Checklist

gemini-code-assist · 2025-12-17T20:42:33Z

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to how previewFeatures are managed within the application's configuration. The primary goal is to ensure that users are automatically opted into preview features, such as Gemini 3, if they haven't explicitly configured their previewFeatures setting. This is achieved by refining the logic that governs model selection, ensuring a seamless transition between default and preview models based on the previewFeatures state, thereby enhancing user experience and feature adoption.

Highlights

Enhanced Preview Feature Handling: The setPreviewFeatures method in the configuration has been refactored to intelligently manage model selection based on the state of preview features. It now ensures that if preview features are enabled while using the default auto model, the system automatically switches to the preview auto model.
Automatic Model Switching: When previewFeatures is enabled and the current model is DEFAULT_GEMINI_MODEL_AUTO, the system will now automatically transition to PREVIEW_GEMINI_MODEL_AUTO. Conversely, if previewFeatures is disabled while a preview model is active, it will revert to DEFAULT_GEMINI_MODEL_AUTO.
New Test Coverage: A new test case has been added to config.test.ts to specifically verify the correct behavior of switching to PREVIEW_GEMINI_MODEL_AUTO when previewFeatures are enabled while the DEFAULT_GEMINI_MODEL_AUTO is active.
Import Updates: The PREVIEW_GEMINI_MODEL_AUTO constant has been imported into both config.ts and config.test.ts to support the new model switching logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces functionality to automatically opt users into preview features based on a remote flag, if they have not configured it themselves. The changes to setPreviewFeatures correctly handle the logic for switching between default and preview auto models when this feature is toggled, and a new test case has been added to verify this. While the implementation within the changed method is sound, I have identified a high-severity race condition in how this method is called from an asynchronous operation in refreshAuth. This could lead to unintentionally overriding a user's explicit preference for preview features.

packages/core/src/config/config.ts

github-actions · 2025-12-17T20:45:25Z

Size Change: +160 B (0%)

Total Size: 22 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	22 MB	+160 B (0%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

packages/core/src/config/config.ts

sehoon38 · 2025-12-17T23:10:56Z

/patch

github-actions · 2025-12-17T23:11:13Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: stable,preview
Commit: a6d1245a54bcc7a4f8b7fd56b5893fcc940ba9fc
Workflows Created: 2

🔗 Track Progress:

github-actions · 2025-12-17T23:12:24Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: preview → will publish to npm tag preview
Commit: a6d1245a54bcc7a4f8b7fd56b5893fcc940ba9fc
Hotfix Branch: hotfix/v0.22.0-preview.1/0.22.0-preview.2/preview/cherry-pick-a6d1245/pr-15214
Hotfix PR: #15226

📝 Next Steps:

Review and approve the hotfix PR: #15226
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #15226

github-actions · 2025-12-17T23:12:54Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: stable → will publish to npm tag latest
Commit: a6d1245a54bcc7a4f8b7fd56b5893fcc940ba9fc
Hotfix Branch: hotfix/v0.21.1/0.21.2/stable/cherry-pick-a6d1245/pr-15214
Hotfix PR: #15227

📝 Next Steps:

Review and approve the hotfix PR: #15227
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #15227

github-actions · 2025-12-17T23:34:24Z

🚀 Patch Release Started!

📋 Release Details:

Environment: prod
Channel: stable → publishing to npm tag latest
Version: v0.21.1
Hotfix PR: Merged ✅
Release Branch: release/v0.21.1-pr-15214

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

View release workflow

github-actions · 2025-12-17T23:34:39Z

🚀 Patch Release Started!

📋 Release Details:

Environment: prod
Channel: preview → publishing to npm tag preview
Version: v0.22.0-preview.1
Hotfix PR: Merged ✅
Release Branch: release/v0.22.0-preview.1-pr-15214

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

View release workflow

github-actions · 2025-12-17T23:56:51Z

✅ Patch Release Complete!

📦 Release Details:

Version: 0.22.0-preview.2
NPM Tag: preview
Channel: preview
Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

GitHub Release: View release v0.22.0-preview.2
NPM Package: npm install @google/gemini-cli@preview

🔗 Links:

github-actions · 2025-12-18T00:05:28Z

✅ Patch Release Complete!

📦 Release Details:

Version: 0.21.2
NPM Tag: latest
Channel: stable
Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

GitHub Release: View release v0.21.2
NPM Package: npm install @google/gemini-cli@latest

🔗 Links:

Respect previewFeatures value from the remote flag if undefined

b9481f8

sehoon38 requested a review from a team as a code owner December 17, 2025 20:42

gemini-code-assist bot reviewed Dec 17, 2025

View reviewed changes

packages/core/src/config/config.ts Show resolved Hide resolved

address race condition

428e000

adamfweidman approved these changes Dec 17, 2025

View reviewed changes

packages/core/src/config/config.ts Show resolved Hide resolved

nit update

107bcc6

sehoon38 enabled auto-merge December 17, 2025 21:34

sehoon38 added this pull request to the merge queue Dec 17, 2025

Merged via the queue into main with commit a6d1245 Dec 17, 2025
20 checks passed

sehoon38 deleted the sehoon/remote_previewFeatures branch December 17, 2025 21:58

github-actions bot pushed a commit that referenced this pull request Dec 17, 2025

Respect previewFeatures value from the remote flag if undefined (#15214)

b699b9e

github-actions bot pushed a commit that referenced this pull request Dec 17, 2025

Respect previewFeatures value from the remote flag if undefined (#15214)

aa4bdd1

jacob314 pushed a commit that referenced this pull request Dec 18, 2025

Respect previewFeatures value from the remote flag if undefined (#15214)

8df6104

Respect previewFeatures value from the remote flag if undefined #15214

Respect previewFeatures value from the remote flag if undefined #15214

Uh oh!

Conversation

sehoon38 commented Dec 17, 2025

Summary

Details

Related Issues

Pre-Merge Checklist

Uh oh!

gemini-code-assist bot commented Dec 17, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sehoon38 commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 17, 2025 •

edited

Loading