Exponential back-off retries for retryable error without a specified … #15684
Conversation
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant improvement to how retryable Google API quota errors are handled, particularly when no specific retry delay is provided by the API. Previously, a fixed 5-second delay was applied, which could be inefficient or contribute to server overload. The changes remove this fixed default, allowing the system to leverage an exponential back-off strategy with jitter. This approach dynamically increases retry intervals, enhancing system resilience, preventing overwhelming the server with repeated requests, and ultimately improving the success rate of operations encountering temporary quota limits. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements exponential backoff for retryable errors that do not specify a retry delay, which is a good improvement over the previous fixed delay. The changes correctly adapt RetryableQuotaError to have an optional retry delay. My review identifies one high-severity issue in the retry logic where a retry delay of 0ms would be handled incorrectly, causing an unnecessary wait instead of an immediate retry. I've provided a suggestion to fix this.
|
Size Change: +176 B (0%) Total Size: 22 MB ℹ️ View Unchanged
|
| constructor( | ||
| message: string, | ||
| override readonly cause: GoogleApiError, | ||
| retryDelayMs?: number, |
There was a problem hiding this comment.
this should've been seconds, not ms
|
/patch |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
#15684) # Conflicts: # packages/core/src/utils/retry.ts
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
#15684) # Conflicts: # packages/core/src/utils/retry.ts
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
2 participants
…delay time
Summary
Perform exponential back-off retries with jitter for retryable error that doesn't have a specified delay time.
Details
When a retryable error is returned without a specified delay, we currently default to a fixed retry interval. This implements exponential backoff to increase the likelihood of success and prevent overwhelming the server.
Related Issues
#15481
How to Validate
Pre-Merge Checklist