Skip to content

Conversation

@sehoon38
Copy link
Collaborator

@sehoon38 sehoon38 commented Jan 2, 2026

Summary

Restore logging for model fallback mode.

Details

This PR reinstates fallback mode logging that was inadvertently removed during recent refactoring/migration to model availability service.

Related Issues

Fixes https://github.com/google-gemini/maintainers-gemini-cli/issues/1174

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an oversight where logging for the model fallback mechanism was inadvertently removed during recent refactoring. It reintroduces this critical logging by creating a dedicated activateFallbackMode method within the Config class, which not only sets the fallback model but also dispatches a telemetry event. This ensures that the system's behavior during model fallbacks is properly recorded and observable, aiding in debugging and performance monitoring.

Highlights

  • Reinstated Fallback Logging: Logging for the model fallback mode, which was previously removed, has been restored to ensure better observability of model behavior.
  • New activateFallbackMode Method: A new method activateFallbackMode has been added to the Config class to centralize the logic for setting a fallback model and logging the corresponding telemetry event.
  • useQuotaAndFallback Hook Update: The useQuotaAndFallback hook now utilizes the new activateFallbackMode method, streamlining the fallback process and ensuring consistent logging.
  • Telemetry Integration: The logFlashFallback telemetry event is now correctly triggered when the system enters fallback mode, providing crucial insights into model behavior and usage patterns.
  • Enhanced Testing: A new test case has been added to validate the functionality of activateFallbackMode, ensuring that fallback models are correctly set and telemetry events are logged as expected.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Size Change: +255 B (0%)

Total Size: 22.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 22.2 MB +255 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restores logging for model fallback mode by introducing a new activateFallbackMode method in the Config class. This method encapsulates setting the fallback model and logging a FlashFallbackEvent for telemetry. The changes are well-structured, moving the logic into a dedicated method for better clarity and maintainability. The corresponding call site in the useQuotaAndFallback hook is updated to use this new method. Additionally, unit tests have been added to verify the new functionality, ensuring the model is set correctly and the telemetry event is logged. The implementation appears correct and effectively addresses the goal of reinstating the fallback logging.

@sehoon38 sehoon38 marked this pull request as ready for review January 2, 2026 16:11
@sehoon38 sehoon38 requested a review from a team as a code owner January 2, 2026 16:11
@sehoon38 sehoon38 added this pull request to the merge queue Jan 2, 2026
Merged via the queue into main with commit 788bb04 Jan 2, 2026
20 checks passed
@sehoon38 sehoon38 deleted the sehoon/fix_flashfallback_logging branch January 2, 2026 18:32
@galz10
Copy link
Collaborator

galz10 commented Jan 6, 2026

/patch preview

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Patch workflow(s) dispatched successfully!

📋 Details:

  • Channels: preview
  • Commit: 788bb04f5c5eec3c8bc4b3ed0dad276355cc2c2b
  • Workflows Created: 1

🔗 Track Progress:

github-actions bot pushed a commit that referenced this pull request Jan 6, 2026
# Conflicts:
#	packages/cli/src/ui/hooks/useQuotaAndFallback.ts
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

🚀 Patch PR Created!

📋 Patch Details:

📝 Next Steps:

  1. ⚠️ Resolve conflicts in the hotfix PR first: #16038
  2. Test your changes after resolving conflicts
  3. Once merged, the patch release will automatically trigger
  4. You'll receive updates here when the release completes

🔗 Track Progress:

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

🚀 Patch Release Started!

📋 Release Details:

  • Environment: prod
  • Channel: preview → publishing to npm tag preview
  • Version: v0.23.0-preview.5
  • Hotfix PR: Merged ✅
  • Release Branch: release/v0.23.0-preview.5-pr-15817

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Patch Release Complete!

📦 Release Details:

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

🔗 Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants