Skip to content

fix(core): append correct OTLP paths for HTTP exporters #16836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebastien-prudhomme wants to merge 3 commits into from
+13 −7
Closed

fix(core): append correct OTLP paths for HTTP exporters #16836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3905e81
fix(core): append correct OTLP paths for HTTP exporters
sebastien-prudhomme Jan 16, 2026
11b0cda
refactor(core): use native URL object for OTLP HTTP path construction
sebastien-prudhomme Jan 16, 2026
ed7697e
Merge remote-tracking branch 'upstream/main' into fix/otlp-http-paths
sebastien-prudhomme Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/src/telemetry/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,13 @@ describe('Telemetry SDK', () => {
await initializeTelemetry(mockConfig);

expect(OTLPTraceExporterHttp).toHaveBeenCalledWith({
url: 'http://localhost:4318/',
url: 'http://localhost:4318/v1/traces',
});
expect(OTLPLogExporterHttp).toHaveBeenCalledWith({
url: 'http://localhost:4318/',
url: 'http://localhost:4318/v1/logs',
});
expect(OTLPMetricExporterHttp).toHaveBeenCalledWith({
url: 'http://localhost:4318/',
url: 'http://localhost:4318/v1/metrics',
});
expect(NodeSDK.prototype.start).toHaveBeenCalled();
});
Expand All @@ -138,7 +138,7 @@ describe('Telemetry SDK', () => {
);
await initializeTelemetry(mockConfig);
expect(OTLPTraceExporterHttp).toHaveBeenCalledWith(
expect.objectContaining({ url: 'https://my-collector.com/' }),
expect.objectContaining({ url: 'https://my-collector.com/v1/traces' }),
);
});

Expand Down
12 changes: 9 additions & 3 deletions packages/core/src/telemetry/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,21 @@ export async function initializeTelemetry(
});
} else if (useOtlp) {
if (otlpProtocol === 'http') {
const buildUrl = (path: string) => {
const url = new URL(parsedEndpoint);
// Join the existing pathname with the new path, handling trailing slashes.
url.pathname = [url.pathname.replace(/\/$/, ''), path].join('/');
return url.href;
};
spanExporter = new OTLPTraceExporterHttp({
url: parsedEndpoint,
url: buildUrl('v1/traces'),
});
logExporter = new OTLPLogExporterHttp({
url: parsedEndpoint,
url: buildUrl('v1/logs'),
});
metricReader = new PeriodicExportingMetricReader({
exporter: new OTLPMetricExporterHttp({
url: parsedEndpoint,
url: buildUrl('v1/metrics'),
}),
exportIntervalMillis: 10000,
});
Expand Down