Cursor support checkpoint

[jacob314]

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the user input experience by updating the ink dependency to a custom version and subsequently refactoring the cursor display mechanism within the InputPrompt component. These changes aim to provide more precise and visually consistent cursor feedback, especially when dealing with empty input fields showing placeholders and when navigating multi-line text.

Highlights

• Dependency Update: The ink dependency has been updated across package.json, package-lock.json, and packages/cli/package.json to point to a specific commit from a GitHub fork (jacob314/ink#4185c82624c1f2712f63a4ef485f6712fde221d4) instead of the npm registry.
• Cursor Rendering Refactor: The InputPrompt component's cursor rendering logic has been refactored to utilize the new terminalCursorFocus and terminalCursorPosition props on Text components, improving cursor display for both placeholder text and active input lines.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +9.98 kB (+0.04%)

Total Size: 23.2 MB

Filename	Size	Change
./bundle/gemini.js	23.1 MB	+9.98 kB (+0.04%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request updates the ink dependency to a forked version from GitHub to add native terminal cursor support. The changes in InputPrompt.tsx correctly utilize the new props from this fork. However, depending on a forked repository via a direct GitHub URL introduces significant maintainability and security risks. My review includes a high-severity comment on this dependency change, recommending a more robust long-term strategy.

[gemini-code-assist]

Using a direct GitHub dependency pinned to a specific commit hash introduces significant risks to the project:

• Maintainability: This approach bypasses standard npm versioning, making it difficult to receive updates, bug fixes, or security patches from the upstream ink package. If the forked repository is removed or made private, it will break the build process.
• Security: The code from this forked commit has not undergone the same vetting process as a published npm package, which could introduce security vulnerabilities.

It is strongly recommended to adopt a more sustainable approach. Please consider one of the following options:

1. If this is a temporary measure for development, document it in the pull request description with a clear plan to revert to an official ink release.
2. For a long-term solution, work on getting these changes merged into the upstream ink repository.
3. As an alternative, publish the forked version to a private npm registry to ensure better version management and build stability.

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request.

To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues.

If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding!