-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Improve CI Times by 70% #8530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI Times by 70% #8530
Conversation
- Parallelize javascript linting in CI - Cache linting dependencies in CI - Use larger runners for CI and E2E - Centralize build step in E2E - Enable parallel testing in E2E
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the performance of the continuous integration (CI) and end-to-end (E2E) workflows. By enabling parallel execution for both Vitest integration tests and npm workspace test commands, the changes aim to reduce overall build and test times, leading to a more efficient development cycle.
Highlights
- Vitest Parallelism: Enabled "fileParallelism" in "integration-tests/vitest.config.ts" to allow Vitest to run test files in parallel, which should significantly speed up integration test execution.
- Parallel Workspace Testing: Added the "--parallel" flag to the "test:ci" script in "package.json" to execute workspace tests concurrently, further reducing CI pipeline time.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR introduces parallel execution for tests to improve CI performance. While this is a good optimization, I've raised concerns in both changed files about the potential for race conditions and test flakiness if the tests are not properly isolated. These changes could impact CI stability if the test suites are not designed to be parallel-safe.
3aa5fc7 to
b12b100
Compare
|
Size Change: +3.49 kB (+0.02%) Total Size: 17.3 MB
ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |


TLDR
This PR introduces several optimizations to the CI and E2E workflows to improve performance and reduce execution time.
Outcomes.