patch e2e vnext #8767
Merged
patch e2e vnext #8767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the end-to-end automation of the patch release process. It introduces new scripts to manage the entire lifecycle, from validating release channels and dynamically naming hotfix branches to triggering the release workflow and providing comprehensive status updates directly on the original pull request. The changes aim to make patch releases more robust, transparent, and user-friendly by connecting various stages of the release pipeline. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the patch release process into separate, more testable scripts, which is a great improvement for maintainability. My review focuses on improving the robustness of these new scripts. I've identified a critical bug that could cause incorrect release status reporting, an inefficient API usage pattern that could lead to performance issues, and a piece of redundant code. Addressing these points will make the new patch process more reliable.
|
Size Change: -2 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
bdmorgan
approved these changes
Sep 18, 2025
galz10
approved these changes
Sep 18, 2025
| } | ||
|
|
||
| // Try to find the original PR that requested this patch | ||
| let originalPr = null; |
Collaborator
There was a problem hiding this comment.
Couldn't this cause silent failures if for some reason we didn't find a pr number
| description: 'The head ref of the merged hotfix PR to trigger the release for (e.g. hotfix/v1.2.3/cherry-pick-abc).' | ||
| required: true | ||
| type: 'string' | ||
| workflow_ref: |
Collaborator
There was a problem hiding this comment.
Shouldn't we add pull-requests: write to both release-patch-2-trigger.yml and release-patch-3-release.yml
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
abhipatel12
pushed a commit
that referenced
this pull request
Sep 19, 2025
nagendrareddy10
pushed a commit
to nagendrareddy10/gemini-cli
that referenced
this pull request
Sep 22, 2025
yashv6655
added a commit
to yashv6655/gemini-cli
that referenced
this pull request
Sep 22, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Oct 3, 2025
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Connect the dots end 2 end
Dive Deeper
More testable, ditch inline scripts