Skip to content

Conversation

@mattKorwel
Copy link
Collaborator

the scripts might not exist for older branches.

@mattKorwel mattKorwel requested review from a team as code owners September 19, 2025 00:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the GitHub Action responsible for publishing releases. The primary goal is to simplify the release workflow by transitioning from a model that involved creating and pushing a dedicated release branch to a more direct tag-based release mechanism. This change aims to make the release process more robust and potentially address issues with script availability or branch management on older or specific branch configurations.

Highlights

  • Release Workflow Simplification: The GitHub Action for publishing releases has been refactored to use a tag-based approach instead of creating a dedicated release branch.
  • Direct Tagging: The workflow now directly creates a Git tag after committing version updates and pushes this tag along with the commit.
  • Removed Branch Dependency: The --target option, which previously pointed to a release branch, has been removed from the gh release create command, streamlining the release creation process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the publish-release GitHub Action to simplify the release process. It removes the creation of a dedicated release branch within the action, and instead performs the version bump, commit, and tagging directly on the currently checked-out branch. This is a good change that makes the action more flexible and reliant on the calling workflow to provide the correct context. However, I've found a critical issue in the new git push command which will fail in common CI scenarios, such as when running in a detached HEAD state. My review includes a suggestion to make the push command more robust.

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Size Change: -2 B (0%)

Total Size: 17.3 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.3 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Adds a concurrency group to the e2e.yml workflow to cancel in-progress runs when new commits are pushed. This mirrors the behavior of the ci.yml workflow.

Also, adds patch_output.log to .gitignore to prevent it from being accidentally committed.
@mattKorwel mattKorwel merged commit bfa4140 into main Sep 19, 2025
19 checks passed
@mattKorwel mattKorwel deleted the patch-process-v4 branch September 19, 2025 01:22
abhipatel12 pushed a commit that referenced this pull request Sep 19, 2025
nagendrareddy10 pushed a commit to nagendrareddy10/gemini-cli that referenced this pull request Sep 22, 2025
yashv6655 added a commit to yashv6655/gemini-cli that referenced this pull request Sep 22, 2025
thacio added a commit to thacio/auditaria that referenced this pull request Oct 3, 2025
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant