-
Notifications
You must be signed in to change notification settings - Fork 10.8k
more patching #8787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more patching #8787
Conversation
Summary of ChangesHello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the GitHub Action responsible for publishing releases. The primary goal is to simplify the release workflow by transitioning from a model that involved creating and pushing a dedicated release branch to a more direct tag-based release mechanism. This change aims to make the release process more robust and potentially address issues with script availability or branch management on older or specific branch configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the publish-release GitHub Action to simplify the release process. It removes the creation of a dedicated release branch within the action, and instead performs the version bump, commit, and tagging directly on the currently checked-out branch. This is a good change that makes the action more flexible and reliant on the calling workflow to provide the correct context. However, I've found a critical issue in the new git push command which will fail in common CI scenarios, such as when running in a detached HEAD state. My review includes a suggestion to make the push command more robust.
|
Size Change: -2 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
Adds a concurrency group to the e2e.yml workflow to cancel in-progress runs when new commits are pushed. This mirrors the behavior of the ci.yml workflow. Also, adds patch_output.log to .gitignore to prevent it from being accidentally committed.
the scripts might not exist for older branches.