-
Notifications
You must be signed in to change notification settings - Fork 10.8k
migrate to patch both #8803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to patch both #8803
Conversation
Summary of ChangesHello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for the /patch command to reflect its new behavior, where it defaults to patching both stable and preview channels. The changes are mostly correct, but the documentation for the --dry-run flag was accidentally removed. I've added a comment to restore it, as it's an important feature for safely testing releases.
| `/patch [channel]` | ||
|
|
||
| - **channel**: `stable` or `preview` | ||
| - **--dry-run** (optional): If included, the workflow will run in dry-run mode. This will create the PR with "[DRY RUN]" in the title, and merging it will trigger a dry run of the final release, so nothing is actually published. | ||
| - **channel** (optional): | ||
| - _no channel_ - patches both stable and preview channels (default, recommended for most fixes) | ||
| - `both` - patches both stable and preview channels (same as default) | ||
| - `stable` - patches only the stable channel | ||
| - `preview` - patches only the preview channel | ||
|
|
||
| Example: `/patch stable --dry-run` | ||
| Examples: | ||
|
|
||
| - `/patch` (patches both stable and preview - default) | ||
| - `/patch both` (patches both stable and preview - explicit) | ||
| - `/patch stable` (patches only stable) | ||
| - `/patch preview` (patches only preview) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for the --dry-run option has been removed in this change. Based on the provided context files, this feature still exists and is critical for testing releases safely. It should be included in the documentation. The command format should be updated to include it, and the explanation and examples should be restored.
| `/patch [channel]` | |
| - **channel**: `stable` or `preview` | |
| - **--dry-run** (optional): If included, the workflow will run in dry-run mode. This will create the PR with "[DRY RUN]" in the title, and merging it will trigger a dry run of the final release, so nothing is actually published. | |
| - **channel** (optional): | |
| - _no channel_ - patches both stable and preview channels (default, recommended for most fixes) | |
| - `both` - patches both stable and preview channels (same as default) | |
| - `stable` - patches only the stable channel | |
| - `preview` - patches only the preview channel | |
| Example: `/patch stable --dry-run` | |
| Examples: | |
| - `/patch` (patches both stable and preview - default) | |
| - `/patch both` (patches both stable and preview - explicit) | |
| - `/patch stable` (patches only stable) | |
| - `/patch preview` (patches only preview) | |
| `/patch [channel] [--dry-run]` | |
| - **channel** (optional): | |
| - _no channel_ - patches both stable and preview channels (default, recommended for most fixes) | |
| - `both` - patches both stable and preview channels (same as default) | |
| - `stable` - patches only the stable channel | |
| - `preview` - patches only the preview channel | |
| - **--dry-run** (optional): If included, the workflow will run in dry-run mode. This will create the PR with "[DRY RUN]" in the title, and merging it will trigger a dry run of the final release, so nothing is actually published. | |
| Examples: | |
| - `/patch` (patches both stable and preview - default) | |
| - `/patch both --dry-run` (dry run for both stable and preview - explicit) | |
| - `/patch stable` (patches only stable) | |
| - `/patch preview --dry-run` (dry run for preview only) |
|
Size Change: -2 B (0%) Total Size: 17.3 MB ℹ️ View Unchanged
|
i wanted to ensure we don't miss any patches.