-
Notifications
You must be signed in to change notification settings - Fork 10.8k
use the cla user #8804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the cla user #8804
Conversation
Summary of ChangesHello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the release script to explicitly set the Git user identity before performing cherry-pick operations. The primary goal is to standardize the attribution of automated commits to the 'gemini-cli-robot' user, enhancing traceability and clarity in the commit history for release-related tasks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds git user configuration to the create-patch-pr.js script to ensure commits created during the cherry-pick process are correctly attributed. My review focuses on improving the maintainability of this change by avoiding hardcoded values. I've suggested using environment variables for the git user and email, which aligns with existing patterns in the codebase.
| run('git config user.name "gemini-cli-robot"', dryRun); | ||
| run('git config user.email "gemini-cli-robot@google.com"', dryRun); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the git user name and email makes this script less portable and harder to maintain. It's better to make these configurable via environment variables, with the current values as defaults. This aligns with the pattern used in other scripts in this repository (e.g., for GITHUB_REPOSITORY_OWNER).
| run('git config user.name "gemini-cli-robot"', dryRun); | |
| run('git config user.email "gemini-cli-robot@google.com"', dryRun); | |
| run('git config user.name "' + (process.env.GIT_USER_NAME || 'gemini-cli-robot') + '"', dryRun); | |
| run('git config user.email "' + (process.env.GIT_USER_EMAIL || 'gemini-cli-robot@google.com') + '"', dryRun); |
|
Size Change: -2 B (0%) Total Size: 17.3 MB βΉοΈ View Unchanged
|
TLDR
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs