Skip to content

Conversation

@mattKorwel
Copy link
Collaborator

TLDR

Dive Deeper

Reviewer Test Plan

Testing Matrix

🍏 πŸͺŸ 🐧
npm run ❓ ❓ ❓
npx ❓ ❓ ❓
Docker ❓ ❓ ❓
Podman ❓ - -
Seatbelt ❓ - -

Linked issues / bugs

@mattKorwel mattKorwel requested a review from a team as a code owner September 19, 2025 03:28
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the release script to explicitly set the Git user identity before performing cherry-pick operations. The primary goal is to standardize the attribution of automated commits to the 'gemini-cli-robot' user, enhancing traceability and clarity in the commit history for release-related tasks.

Highlights

  • Git User Configuration: The script now explicitly configures the Git user name and email to 'gemini-cli-robot' and 'gemini-cli-robot@google.com' respectively.
  • Automated Commit Attribution: This change ensures that all commits made during the automated cherry-picking process within the release script are consistently attributed to a dedicated bot user.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds git user configuration to the create-patch-pr.js script to ensure commits created during the cherry-pick process are correctly attributed. My review focuses on improving the maintainability of this change by avoiding hardcoded values. I've suggested using environment variables for the git user and email, which aligns with existing patterns in the codebase.

Comment on lines +100 to +101
run('git config user.name "gemini-cli-robot"', dryRun);
run('git config user.email "gemini-cli-robot@google.com"', dryRun);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hardcoding the git user name and email makes this script less portable and harder to maintain. It's better to make these configurable via environment variables, with the current values as defaults. This aligns with the pattern used in other scripts in this repository (e.g., for GITHUB_REPOSITORY_OWNER).

Suggested change
run('git config user.name "gemini-cli-robot"', dryRun);
run('git config user.email "gemini-cli-robot@google.com"', dryRun);
run('git config user.name "' + (process.env.GIT_USER_NAME || 'gemini-cli-robot') + '"', dryRun);
run('git config user.email "' + (process.env.GIT_USER_EMAIL || 'gemini-cli-robot@google.com') + '"', dryRun);

@mattKorwel mattKorwel merged commit 2993800 into main Sep 19, 2025
8 of 9 checks passed
@mattKorwel mattKorwel deleted the patch10 branch September 19, 2025 03:29
@github-actions
Copy link

Size Change: -2 B (0%)

Total Size: 17.3 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.3 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

abhipatel12 pushed a commit that referenced this pull request Sep 19, 2025
nagendrareddy10 pushed a commit to nagendrareddy10/gemini-cli that referenced this pull request Sep 22, 2025
yashv6655 added a commit to yashv6655/gemini-cli that referenced this pull request Sep 22, 2025
thacio added a commit to thacio/auditaria that referenced this pull request Oct 3, 2025
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant