-
Notifications
You must be signed in to change notification settings - Fork 3k
Change of default model #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…view-05-2025, cause default is depreceated and not useful
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @P47Parzival, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the default AI model configured within the frontend application. The change replaces a deprecated Gemini model with its newer counterpart, "gemini-2.5-flash-preview-05-2025", to maintain compatibility and ensure the application continues to function with up-to-date services. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the default model from a deprecated version to a newer one in the frontend. The change is straightforward and addresses the issue described. I've added one suggestion to improve maintainability by refactoring the hardcoded model names into constants or a data structure. This will make future updates to the available models easier and less error-prone.
| const [internalInputValue, setInternalInputValue] = useState(""); | ||
| const [effort, setEffort] = useState("medium"); | ||
| const [model, setModel] = useState("gemini-2.5-flash-preview-04-17"); | ||
| const [model, setModel] = useState("gemini-2.5-flash-preview-05-2025"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using hardcoded strings like gemini-2.5-flash-preview-05-2025 in multiple places (here and on line 147) can make the code harder to maintain and lead to potential errors if the value needs to be updated.
To improve this, consider defining constants for the model names at the top of your component or in a separate constants file.
const MODEL_GEMINI_2_5_FLASH = "gemini-2.5-flash-preview-05-2025";
// ...
const [model, setModel] = useState(MODEL_GEMINI_2_5_FLASH);For an even more robust solution, you could define all models in an array of objects and generate the SelectItem components dynamically by mapping over this array. This would centralize all model-related information (value, label, icon) and make the component cleaner and easier to maintain.
Change default gemini-2.5-flash-preview-04-17 to gemini-2.5-flash-preview-05-2025, cause default is depreceated and not useful