fix: mitigate prompt injection in issue triage workflows #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cornmander
requested review from
sethvargo,
verbanicm,
bdmorgan and
aliciatang07
jerop
reviewed
Aug 13, 2025
| uses: './' | ||
| id: 'gemini_issue_triage' | ||
| id: 'suggest_labels' | ||
| env: | ||
| GITHUB_TOKEN: '${{ steps.generate_token.outputs.token || secrets.GITHUB_TOKEN }}' |
There was a problem hiding this comment.
can we remove this too by fetching labels upfront? then we can also remove gh label list
sethvargo
reviewed
Aug 13, 2025
| LABELS_TO_APPLY: '${{ steps.suggest_labels.outputs.result }}' | ||
| ISSUE_NUMBER: '${{ github.event.issue.number }}' | ||
| run: | | ||
| set -euo pipefail |
There was a problem hiding this comment.
Do we really need all this bash? It seems pretty brittle... I wonder if we could export JSON or something machine-parseable instead? Alternatively, could we use the action-script action to do this in node, which would likely be a bit cleaner?
There was a problem hiding this comment.
Implemented this approach in #171
|
Superceeded by #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigates a prompt injection vulnerability in the issue triage workflows by separating the label suggestion and application steps.