Skip to content

feat: support direct wif #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support direct wif #380

wants to merge 1 commit into from
+29 −5

Conversation

@fredrikaverpil
Copy link

@fredrikaverpil fredrikaverpil commented Oct 24, 2025 •
edited
Loading

Why this change?

Fix #379 - Service account is not actually optional, but it says so in the README.

What?

  • Add support for direct WIF my making access_token and gcp_access_token_scopes into configurable inputs.

Notes

  • This is not a backwards compatibility breaking change, as I added the current values into the new inputs' defaults.
  • Another approach could be to not introduce any new inputs, and instead have two variants of the authentication step; one that works like today, and one which doesn't set access_token if no service account was specified. This would require some minor changes to the WIF validation logic in the action.

@fredrikaverpil fredrikaverpil marked this pull request as ready for review October 24, 2025 13:42
@fredrikaverpil fredrikaverpil requested review from a team as code owners October 24, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@R2wenD2 R2wenD2 Awaiting requested review from R2wenD2 R2wenD2 is a code owner automatically assigned from google-github-actions/maintainers

@verbanicm verbanicm Awaiting requested review from verbanicm verbanicm is a code owner automatically assigned from google-github-actions/maintainers

@chrstnb chrstnb Awaiting requested review from chrstnb chrstnb is a code owner automatically assigned from google-github-actions/run-gemini-cli-maintainers

@JeromeJu JeromeJu Awaiting requested review from JeromeJu JeromeJu is a code owner automatically assigned from google-github-actions/run-gemini-cli-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Service Account is not optional

1 participant

@fredrikaverpil