feat: support direct wif #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikaverpil
force-pushed
the
direct-wif
branch
from
41eed13 to
f8a8dc6
Compare
fredrikaverpil
force-pushed
the
direct-wif
branch
from
f8a8dc6 to
a061205
Compare
fredrikaverpil
requested review from
JeromeJu,
R2wenD2,
chrstnb and
verbanicm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
Fix #379 - Service account is not actually optional, but it says so in the README.
What?
access_tokenandgcp_access_token_scopesinto configurable inputs.Notes
access_tokenif no service account was specified. This would require some minor changes to the WIF validation logic in the action.