Skip to content

No public description #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

No public description #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion weatherbenchX/binning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ class BySets(Binning):

def __init__(
self,
sets: Mapping[str, Sequence[Any]],
sets: Mapping[str, Sequence[Any] | Any],
coord_name: str,
bin_dim_name: Optional[str] = None,
add_set_complements: bool = False,
Expand Down
24 changes: 20 additions & 4 deletions weatherbenchX/binning_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,12 @@ def test_by_sets(self):
'2m_temperature'
]

scalar_station = statistic.stationName[0]
bins = binning.BySets(
{
'set1': statistic.stationName[:10],
'set2': statistic.stationName[10:20],
'scalar_set': scalar_station,
'empty_set': [],
'wrong_set': [1, 2, 3, 4],
},
Expand All @@ -246,9 +248,13 @@ def test_by_sets(self):
)

mask = bins.create_bin_mask(statistic)
self.assertLen(mask.station_subset, 5)
self.assertLen(mask.station_subset, 6)
self.assertGreaterEqual(mask.sum('index').sel(station_subset='set1'), 10)
self.assertGreaterEqual(mask.sum('index').sel(station_subset='set2'), 10)
self.assertEqual(
mask.sum('index').sel(station_subset='scalar_set'),
(statistic.stationName == scalar_station).sum(),
)
self.assertEqual(mask.sum('index').sel(station_subset='empty_set'), 0)
self.assertEqual(mask.sum('index').sel(station_subset='wrong_set'), 0)
self.assertLen(statistic, mask.sum('index').sel(station_subset='global'))
Expand Down Expand Up @@ -278,9 +284,15 @@ def test_latitude_bins(self, degrees, lat_range, expected_bins):
lon_idx = np.argmin(np.abs(statistic_values.longitude.values - 0))

# Find the bin that contains the selected latitude
expected_bin_idx = (statistic_values.latitude.values[lat_idx] - lat_range[0]) // degrees
expected_bin_idx = (
statistic_values.latitude.values[lat_idx] - lat_range[0]
) // degrees
self.assertTrue(
mask.isel(latitude_bins=int(expected_bin_idx), latitude=lat_idx, longitude=lon_idx).values.all()
mask.isel(
latitude_bins=int(expected_bin_idx),
latitude=lat_idx,
longitude=lon_idx,
).values.all()
)

@parameterized.parameters(
Expand Down Expand Up @@ -311,7 +323,11 @@ def test_longitude_bins(self, degrees, lon_range, expected_bins, test_lon):
expected_bin_idx = (lon_val - lon_range[0]) // degrees

self.assertTrue(
mask.isel(longitude_bins=int(expected_bin_idx), latitude=lat_idx, longitude=lon_idx).values.all()
mask.isel(
longitude_bins=int(expected_bin_idx),
latitude=lat_idx,
longitude=lon_idx,
).values.all()
)


Expand Down
Loading