Add more categorical metrics and fix the argument 'dims' renames as 'dim' of the xarray.dot #74
Open
LQscience wants to merge 3 commits intogoogle-research:mainfrom
Open
Conversation
modified: weatherbenchX/metrics/categorical.py modified: weatherbenchX/metrics/metrics_test.py
raspstephan
approved these changes
Jun 11, 2025
Collaborator
raspstephan
left a comment
raspstephan
left a comment
There was a problem hiding this comment.
This is amazing. Thank you so much!
Collaborator
|
Sorry for the delay. There will be an update soon that fixes the unit tests. Then we can proceed with merging this. |
Collaborator
|
Sorry for the long wait. There is a conflict now. If you could fix that, we can submit the PR soon. |
Contributor
Author
OK, I am going to handle with this issue. |
raspstephan
requested changes
Jul 28, 2025
Collaborator
There was a problem hiding this comment.
We will update the xarray requirement to >=2025.07 which should make this change unnecessary since unfortunately this change won't work for us internally.
Collaborator
There was a problem hiding this comment.
The updated has now been merged, so the tests should run even without this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified: weatherbenchX/metrics/categorical.py
modified: weatherbenchX/metrics/metrics_test.py
The calculation functions of false alarm rate, true negative rate, Peirce’s skill score, odds ratio skill score and extremal dependence index are added into the 'weatherbenchX/metrics/categorical.py'. In the meantime, their test functions are added into the 'weatherbenchX/metrics/metrics_test.py'
modified: weatherbenchX/aggregation.py
modified: weatherbenchX/metrics/categorical.py
The
dimsargument has been renamed todim, and will be removed in the future. This renaming is taking place throughout xarray over the next few releases.