Move web tests into lib (which is what they test) #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ava-cassiopeia
force-pushed
the
avac-move-tests
branch
from
217e258 to
f496692
Compare
ava-cassiopeia
force-pushed
the
avac-lit-dir
branch
from
675121c to
127ab74
Compare
ava-cassiopeia
force-pushed
the
avac-move-tests
branch
from
f496692 to
7fd0763
Compare
zbirkenbuel
approved these changes
Nov 26, 2025
jacobsimionato
approved these changes
Nov 26, 2025
ava-cassiopeia
force-pushed
the
avac-lit-dir
branch
from
7e4af68 to
1cfdec8
Compare
ava-cassiopeia
force-pushed
the
avac-move-tests
branch
3 times, most recently
from
b4ee0d4 to
db87dcd
Compare
ava-cassiopeia
force-pushed
the
avac-lit-dir
branch
from
051a528 to
6a34b8b
Compare
This allows for stacking of PRs
ava-cassiopeia
force-pushed
the
avac-move-tests
branch
from
db87dcd to
1bd808a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the web test file into
web/lib/, because it only tests the web lib's functionality to begin with and doesn't make sense as a separate project.In the process I switched the type-checking strictness to true for the test file, which caught a typing error: it seems like we want to have recursive value maps (the test implies this, anyway) so I updated the type to reflect that. However, that broke some other typecasting happening in
model-processor.ts. I took a stab at resolving it, but would love some insight on the right way to approach this from someone who's been on this project longer.