Skip to content

Simplify ModelProcessor by extending A2UIModelProcessor #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ava-cassiopeia merged 1 commit into from
Dec 1, 2025
Merged

Simplify ModelProcessor by extending A2UIModelProcessor #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 6 additions & 28 deletions angular/projects/lib/src/lib/data/processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,41 +24,19 @@ export interface DispatchedEvent {
}

@Injectable({ providedIn: 'root' })
export class ModelProcessor {
private readonly processor = new v0_8.Data.A2UIModelProcessor();
export class ModelProcessor extends v0_8.Data.A2UIModelProcessor {
readonly events = new Subject<DispatchedEvent>();

getSurfaces() {
return this.processor.getSurfaces();
}

resolvePath(path: string, dataContextPath?: string) {
return this.processor.resolvePath(path, dataContextPath);
}

setData(
override setData(
node: v0_8.Types.AnyComponentNode,
relativePath: string,
value: v0_8.Types.DataValue,
surfaceId?: v0_8.Types.SurfaceID | null
) {
return this.processor.setData(node, relativePath, value, surfaceId ?? undefined);
}

getData(
node: v0_8.Types.AnyComponentNode,
relativePath: string,
surfaceId?: string
): v0_8.Types.DataValue | null {
return this.processor.getData(node, relativePath, surfaceId);
}

clearSurfaces() {
this.processor.clearSurfaces();
}

processMessages(messages: v0_8.Types.ServerToClientMessage[]) {
this.processor.processMessages(messages);
// Override setData to convert from optional inputs (which can be null)
// to undefined so that this correctly falls back to the default value for
// surfaceId.
return super.setData(node, relativePath, value, surfaceId ?? undefined);
}

dispatch(message: v0_8.Types.A2UIClientEventMessage): Promise<v0_8.Types.ServerToClientMessage[]> {
Expand Down