Move Angular code around#238
Merged
crisbeto merged 3 commits intogoogle:mainfrom Dec 8, 2025
crisbeto:samples-dir
Merged
Conversation
Moves the Angular renderer code under `renderers` and the examples under `samples`.
We want the Angular renderer to be under `renderers` while the examples should be under `samples/client`. This doesn't work with the Angular CLI which requires the `angular.json` to be at the root. These changes work around it by symlinking the renderer back into the samples directory.
sugoi-yuzuru
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Angular code based on #176. Note that I had to resort to symlinking the
renderers/angular/srcdirectory, because we want the Angular renderer to be underrendererswhile the examples should be undersamples/client. This doesn't work with the Angular CLI which requires theangular.jsonto be at the root.