feat: improve Lit client robustness for message handling#419
Open
doitundoit wants to merge 2 commits intogoogle:mainfrom
Open
feat: improve Lit client robustness for message handling#419doitundoit wants to merge 2 commits intogoogle:mainfrom
doitundoit wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add fallback mechanism to retrieve agent messages from history when status.message.parts is empty - Handle string-encoded JSON data parts by parsing them - Add debug logging (console.debug) for better traceability
doitundoit
force-pushed
the
feat/lit-client-robustness
branch
from
730b139 to
9560b98
Compare
paullewis
approved these changes
Jan 5, 2026
Collaborator
paullewis
left a comment
paullewis
left a comment
There was a problem hiding this comment.
Nit: might be worth adding a bit of an explanation to this but approving all the same.
Contributor
Author
Hi, thanks for the feedback! I've added concise comments explaining the rationale behind the history fallback and JSON parsing logic for better clarity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Lit client's robustness when handling agent response messages.
Changes
status.message.partsis emptyconsole.debugstatements for better traceability during developmentAffected file:
samples/client/lit/shell/client.tsVerification
npm run build:tsc)Related
Split from #396 as requested by reviewer to keep commit scope narrow and targeted.