Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds uv as a prerequisite to the Angular client samples' README file and includes several formatting improvements. I've suggested a couple of fixes to the list formatting in the README to ensure they are rendered correctly as sub-lists. Additionally, the pull request description is incomplete. According to the repository's style guide (lines 18-20), the pre-review checklist should be completed. Please update the description to reflect the work done and fill out the checklist.
Description
Updated /samples/client/angular/README.md to mention that uv is a prerequisite.
Without
uvinstalled, running$ npm run demo:restauranton Mac fails:Pre-launch Checklist