Skip to content

Add uv as a prerequisite#740

Open
josemontesp wants to merge 5 commits intogoogle:mainfrom
josemontesp:uv-prerequisite
Open

Add uv as a prerequisite#740
josemontesp wants to merge 5 commits intogoogle:mainfrom
josemontesp:uv-prerequisite

Conversation

@josemontesp
Copy link

@josemontesp josemontesp commented Mar 2, 2026

Description

Updated /samples/client/angular/README.md to mention that uv is a prerequisite.

Without uv installed, running $ npm run demo:restaurant on Mac fails:

$ npm run demo:restaurant
> angular-a2ui@0.0.0 demo:restaurant
> npm run build:web_core && concurrently -k -n "AGENT,WEB" -c "magenta,blue" "npm run serve:agent:restaurant" "npm start -- restaurant"


> angular-a2ui@0.0.0 build:web_core
> cd ../../../renderers/web_core && npm install && npm run build


up to date, audited 37 packages in 429ms

5 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> @a2ui/web_core@0.8.2 build
> wireit

✅ Ran 0 scripts and skipped 2 in 0.1s.
[AGENT] 
[AGENT] > angular-a2ui@0.0.0 serve:agent:restaurant
[AGENT] > cd ../../agent/adk/restaurant_finder && uv run .
[AGENT] 
[WEB] 
[WEB] > angular-a2ui@0.0.0 start
[WEB] > ng serve restaurant
[WEB] 
[AGENT] sh: uv: command not found
[AGENT] npm run serve:agent:restaurant exited with code 127
--> Sending SIGTERM to other processes..
[WEB] npm start -- restaurant exited with code SIGTERM

Pre-launch Checklist

@google-cla
Copy link

google-cla bot commented Mar 2, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds uv as a prerequisite to the Angular client samples' README file and includes several formatting improvements. I've suggested a couple of fixes to the list formatting in the README to ensure they are rendered correctly as sub-lists. Additionally, the pull request description is incomplete. According to the repository's style guide (lines 18-20), the pre-review checklist should be completed. Please update the description to reflect the work done and fill out the checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants