Open
Conversation
1. Image needs to have an `altText`. If not specified, it defaults to an empty string, which indicates to a screen reader to skip the image entirely, assuming it is decorative. 2. Icons need to ensure they are not in the tab order.
jgindin
requested review from
ava-cassiopeia,
crisbeto,
ditman and
jacobsimionato
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to improve accessibility for images and icons. The changes for icons are good, but there are a few issues with the implementation for image altText. I've found a critical type definition error, a potential runtime error in data binding, and a minor opportunity for code clarification. My comments provide specific suggestions to address these points.
sugoi-yuzuru
reviewed
Mar 2, 2026
sugoi-yuzuru
reviewed
Mar 2, 2026
sugoi-yuzuru
reviewed
Mar 2, 2026
sugoi-yuzuru
approved these changes
Mar 2, 2026
| inputBinding('url', () => properties.url), | ||
| inputBinding('usageHint', () => properties.usageHint), | ||
| inputBinding('altText', () => properties.altText), | ||
| inputBinding('altText', () => properties.altText ?? null), |
Collaborator
There was a problem hiding this comment.
| | null seems to be the approach more aligned with the rest of the file to set default value here.
| protected readonly resolvedAltText = computed(() => { | ||
| const raw = this.altText(); | ||
| return raw ? this.resolvePrimitive(raw) : ''; | ||
| return (raw ? this.resolvePrimitive(raw) : null) ?? ''; |
Collaborator
There was a problem hiding this comment.
This could be as simple as
return this.resolvePrimitive(this.altText()) ?? '';`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
altText. If not specified, it defaults to an empty string, which indicates to a screen reader to skip the image entirely, assuming it is decorative.Pre-launch Checklist