-
Notifications
You must be signed in to change notification settings - Fork 245
Add async and await support to DaysUntilBirthday Swift sample app #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdmathias
wants to merge
14
commits into
main
Choose a base branch
from
mdmathias/async-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
db1677e
Use async await API in DaysUntilBirthday Sample App
mdmathias bd642fd
Merge branch 'main' into mdmathias/async-support
petea 7ac0d3d
Remove configuration references.
petea 0d1f63d
Use correct method signature.
petea 0f00694
Merge branch 'main' into mdmathias/async-support
petea a75b5ab
Cleanup.
petea 38a5f5c
Merge branch 'main' into mdmathias/async-support
petea c1c4afe
Update GIDUserAuth refs to GIDSignInResult.
petea c57d715
Ensure calls to GSI are made on the main thread.
petea d0deb73
Fix build error by using MainActor on individual methods.
petea 3cd4564
Remove unnecessary MainActor annotations.
petea 560554e
No need to signOut after disconnect.
petea 707db4d
GoogleSignInAuthenticator is no longer Observable.
petea a680352
Return MainActor annotations.
petea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.