Skip to content

GIDTokenClaim Implementation + Unit Tests #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkshatG6 merged 3 commits into from
Sep 5, 2025
Merged

GIDTokenClaim Implementation + Unit Tests #550

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6648e4f
GIDTokenClaim Implementation + Unit Tests
AkshatG6 Sep 3, 2025
6ecc98e
Added const string in GIDTokenClaimTests
AkshatG6 Sep 4, 2025
9378563
Updated GIDTokenClaim Implementation + Tests with const string
AkshatG6 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions GoogleSignIn/Tests/Unit/GIDTokenClaimTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,23 @@

#import <XCTest/XCTest.h>
#import "GoogleSignIn/Sources/Public/GoogleSignIn/GIDTokenClaim.h"

static NSString *const kAuthTimeClaimName = @"auth_time";
Copy link
Collaborator

@mdmathias mdmathias Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be declared in GIDTokenClaim.h, implemented and used in GIDTokenClaim.m


@interface GIDTokenClaimTest : XCTestCase
@end

@implementation GIDTokenClaimTest

- (void)testAuthTimeClaim_PropertiesAreCorrect {
GIDTokenClaim *claim = [GIDTokenClaim authTimeClaim];
XCTAssertEqualObjects(claim.name, @"auth_time");
XCTAssertEqualObjects(claim.name, kAuthTimeClaimName);
XCTAssertFalse(claim.isEssential);
}

- (void)testEssentialAuthTimeClaim_PropertiesAreCorrect {
GIDTokenClaim *claim = [GIDTokenClaim essentialAuthTimeClaim];
XCTAssertEqualObjects(claim.name, @"auth_time");
XCTAssertEqualObjects(claim.name, kAuthTimeClaimName);
XCTAssertTrue(claim.isEssential);
}

Expand Down