Skip to content

Conversation

@dantelmomsft
Copy link
Contributor

@dantelmomsft dantelmomsft commented Jul 3, 2025

fix #239 .
@glaforge

Copy link
Contributor

@glaforge glaforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting the problem and for fixing it as well! Great job!

@dantelmomsft dantelmomsft changed the title fixing multiple tool requests with langchain4j fix: multiple tool requests with langchain4j Jul 4, 2025
@Poggecci Poggecci self-requested a review July 4, 2025 21:46
@shukladivyansh
Copy link
Contributor

Thanks for the change.

Can you format it with https://github.com/google/google-java-format

@dantelmomsft
Copy link
Contributor Author

dantelmomsft commented Jul 8, 2025

Thanks for the change.

Can you format it with https://github.com/google/google-java-format

@shukladivyansh I've run the the formatter available in parent maven config. hope this is ok.

@Poggecci
Copy link
Contributor

Poggecci commented Jul 8, 2025

From our commit CI

This pull request has 2 commits.
Please squash them into a single commit before merging.
You can use git rebase -i HEAD~N
...where N is the number of commits you want to squash together. The PR check conveniently tells you this number! For example, if the check says you have 3 commits, you would run: git rebase -i HEAD~3.
Because you have rewritten the commit history, you must use the --force flag to update the pull request: git push --force

Please run the commands above to squash to 1 commit please! (this helps keep our git history cleaner when using Copybara which lacks squash commit functionality)

@dantelmomsft
Copy link
Contributor Author

From our commit CI

This pull request has 2 commits.
Please squash them into a single commit before merging.
You can use git rebase -i HEAD~N
...where N is the number of commits you want to squash together. The PR check conveniently tells you this number! For example, if the check says you have 3 commits, you would run: git rebase -i HEAD~3.
Because you have rewritten the commit history, you must use the --force flag to update the pull request: git push --force

Please run the commands above to squash to 1 commit please! (this helps keep our git history cleaner when using Copybara which lacks squash commit functionality)

@Poggecci done

@Poggecci
Copy link
Contributor

Poggecci commented Jul 11, 2025

Thank you @dantelmomsft. When merging this I actually noticed that there's a slight mismatch in the internal formatter vs the java plugin (internal formatted one of the strings in the test!). I'll be updating the CI to not block external contributions for this in the future and for this PR I'm submitting a manual format fix (#259) so this PR should be auto-merged today when that fix gets in. Sorry for the churn on this!

copybara-service bot pushed a commit that referenced this pull request Jul 12, 2025
Merge #246

fix #239 .
@glaforge

COPYBARA_INTEGRATE_REVIEW=#246 from dantelmomsft:main bcb5431
PiperOrigin-RevId: 782170311
@Poggecci
Copy link
Contributor

Strange that Copybara committed this but left the PR open...

@Jacksunwei
Copy link
Contributor

Merged in 92631a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Langchain4j - Multiple tool execution requests

5 participants