-
Notifications
You must be signed in to change notification settings - Fork 256
fix: multiple tool requests with langchain4j #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
glaforge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for spotting the problem and for fixing it as well! Great job!
|
Thanks for the change. Can you format it with https://github.com/google/google-java-format |
@shukladivyansh I've run the the formatter available in parent maven config. hope this is ok. |
|
From our commit CI Please run the commands above to squash to 1 commit please! (this helps keep our git history cleaner when using Copybara which lacks squash commit functionality) |
@Poggecci done |
|
Thank you @dantelmomsft. When merging this I actually noticed that there's a slight mismatch in the internal formatter vs the java plugin (internal formatted one of the strings in the test!). I'll be updating the CI to not block external contributions for this in the future and for this PR I'm submitting a manual format fix (#259) so this PR should be auto-merged today when that fix gets in. Sorry for the churn on this! |
|
Strange that Copybara committed this but left the PR open... |
|
Merged in 92631a1 |
fix #239 .
@glaforge