fix: Runner now includes Singles from appendEvent in the Rx graph #260
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_782018177
branch
from
d05fff3 to
001574d
Compare
Previously, the return values from sessionManager.appendEvent were disarded, leading to issues if that Single did not represent an immediate value. For example, if a SessionManager implementation performed async work such as persisting the new event to an external datastore that work would never occur. PiperOrigin-RevId: 782076407
copybara-service
bot
force-pushed
the
test_782018177
branch
from
001574d to
b862ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Runner now includes Singles from appendEvent in the Rx graph
Previously, the return values from sessionManager.appendEvent were disarded, leading to issues if that Single did not represent an immediate value. For example, if a SessionManager implementation performed async work such as persisting the new event to an external datastore that work would never occur.