-
Notifications
You must be signed in to change notification settings - Fork 261
feature: support async mcp tool client #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
119ebf9 to
86ebe47
Compare
86ebe47 to
4d40166
Compare
Poggecci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot for this contribution!
Would you mind updating the description briefly detailing why the Async client was necessary for your use case? Would love to better understand and see if we should update our docs to default to the Async over the sync client
Thanks for you relay. I am building an Agent service based on Java, providing RESTful APIs through Spring Boot Webflux. ADK-Java meets my needs. Meanwhile, it is developed based on RxJava. Although it and Reactor in Webflux are two different reactive frameworks, it's not a problem. Asynchronous and reactive technology stacks are exactly what I want. But in the process of me gradually delving into using ADK, I found that in the link based on the asynchronous technology stack: 1 McpTool is actually an implementation based on McpSyncClient. |
6c377e0 to
7d62b21
Compare
So, I think it's a better choice to use asynchronous clients in the asynchronous link. |
7d62b21 to
0c50970
Compare
|
Can we also either update core/src/main/java/com/google/adk/tools/mcp/McpToolset.java to allow choosing, or create an |
|
In my opinion, it might be better to create an McpAsyncToolset first, and then gradually and smoothly migrate the McpToolset to McpAsyncToolset. |
|
I'll add McpAsyncToolset later |
The pr for McpAsyncToolset: #306 |
support async-mcp-client