Skip to content

Conversation

artur-ciocanu
Copy link
Contributor

Currently neither ApiResponse not HttpApiResponse from network package is used. It is better to get rid of these classes, so we reduce the code footprint and maintenance burden.

Copy link

google-cla bot commented Aug 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @artur-ciocanu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've removed the network package, specifically the ApiResponse and HttpApiResponse classes, as they were found to be unused. This change aims to reduce the overall code footprint and simplify future maintenance efforts by eliminating dead code.

Highlights

  • Code Removal: Eliminated the ApiResponse abstract class from the network package.
  • Code Removal: Removed the HttpApiResponse concrete class, which extended ApiResponse and handled HTTP responses.
  • Code Quality: Reduced the project's code footprint and maintenance burden by cleaning up unused components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to remove the unused network package. While it's true that the classes ApiResponse and HttpApiResponse from this package are not directly imported, the deleted HttpApiResponse contains critical error handling logic that is missing from its replacement in the sessions package. Removing this file without migrating the error handling logic could lead to silent failures when encountering server or client errors. I've left a comment on the deleted file with more details. This issue should be addressed before merging.

@shukladivyansh shukladivyansh self-assigned this Aug 11, 2025
@shukladivyansh
Copy link
Collaborator

shukladivyansh commented Aug 11, 2025

Hi Artur!

Thanks for the contribution. Lgtm.

@shukladivyansh
Copy link
Collaborator

@artur-ciocanu Can you sign the google cla? That is needed to contribute to the repo

@artur-ciocanu artur-ciocanu force-pushed the remove-network-package branch from ed67b5e to a3c47bc Compare August 12, 2025 23:32
@artur-ciocanu
Copy link
Contributor Author

@shukladivyansh thanks a lot for looking into this. I have signed the CLA and things are looking good.

@artur-ciocanu
Copy link
Contributor Author

@shukladivyansh I see that the build-modules failed with:

Failures: 
Error:    StreamingToolTest.runLive_videoStreamingTool_receivesVideoFramesAndSendsResultsToLlm:343 missing (3): Function monitorVideoStream returned: {people_count_alert=Processed frame: detected 2 people} [3 copies]

I don't think this failure is related to my changes.

Could you please let me know how should proceed? Thank you.

@copybara-service copybara-service bot merged commit 8d34f59 into google:main Aug 13, 2025
5 of 7 checks passed
@artur-ciocanu artur-ciocanu deleted the remove-network-package branch August 13, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants