Skip to content

fix: live agents using Gemini don't call tools #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 9, 2025
+14 −6
Merged

fix: live agents using Gemini don't call tools #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/java/com/google/adk/models/GeminiLlmConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,10 @@ public Completable sendContent(Content content) {
.build());
} else {
return sendClientContentInternal(
LiveSendClientContentParameters.builder().turns(ImmutableList.of(content)).build());
LiveSendClientContentParameters.builder()
.turns(ImmutableList.of(content))
.turnComplete(true)
.build());
}
}

Expand Down
15 changes: 10 additions & 5 deletions core/src/main/java/com/google/adk/tools/BaseTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.errorprone.annotations.CanIgnoreReturnValue;
import com.google.genai.types.FunctionDeclaration;
import com.google.genai.types.GenerateContentConfig;
import com.google.genai.types.LiveConnectConfig;
import com.google.genai.types.Tool;
import io.reactivex.rxjava3.core.Completable;
import io.reactivex.rxjava3.core.Single;
Expand Down Expand Up @@ -110,19 +111,23 @@ public Completable processLlmRequest(
.build())
.build();
}
ImmutableList<Tool> newTools =
new ImmutableList.Builder<Tool>()
.addAll(toolsWithoutFunctionDeclarations)
.add(toolWithFunctionDeclarations)
.build();
// Patch the GenerateContentConfig with the new tool definition.
GenerateContentConfig generateContentConfig =
llmRequest
.config()
.map(GenerateContentConfig::toBuilder)
.orElse(GenerateContentConfig.builder())
.tools(
new ImmutableList.Builder<Tool>()
.addAll(toolsWithoutFunctionDeclarations)
.add(toolWithFunctionDeclarations)
.build())
.tools(newTools)
.build();
LiveConnectConfig liveConnectConfig =
llmRequest.liveConnectConfig().toBuilder().tools(newTools).build();
llmRequestBuilder.config(generateContentConfig);
llmRequestBuilder.liveConnectConfig(liveConnectConfig);
return Completable.complete();
}

Expand Down