Skip to content

Conversation

TomorJM
Copy link
Contributor

@TomorJM TomorJM commented Aug 12, 2025

This commit adds a new configuration option sseEndpoint to the SseServerParameters class, which is used to specify the exact endpoint for connecting to the SSE server. It also updates the related processing logic in DefaultMcpTransportBuilder to ensure the configuration is applied correctly.

In the Java DefaultMcpTransportBuilder implementation, when constructing the HttpClientSseClientTransport, the sseEndpoint parameter is hardcoded to "sse" by default. However, in the official MCP implementation, the following line:

image
URI clientUri = Utils.resolveUri(this.baseUri, this.sseEndpoint);

will normalize a URL like "http://testurl/sse?param=xxx" into "http://testurl/sse", leading to the loss of query parameters.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @TomorJM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option, sseEndpoint, within the SseServerParameters class. This addition allows for explicit definition of the Server-Sent Events (SSE) connection endpoint, addressing an issue where the default URI resolution logic in HttpClientSseClientTransport could inadvertently strip query parameters from the SSE URL. By making the endpoint configurable, the change ensures proper URI handling and prevents potential data loss during SSE connection establishment.

Highlights

  • New Configuration Option for SSE Endpoint: A new abstract method, sseEndpoint(), has been added to the SseServerParameters class, allowing users to specify the exact endpoint path for connecting to the SSE server. This provides greater control over the URI construction.
  • Integration of Configurable SSE Endpoint: The DefaultMcpTransportBuilder has been updated to utilize the new sseEndpoint from SseServerParameters. If the sseEndpoint is not explicitly provided, it will default to "sse", ensuring backward compatibility while allowing for custom endpoint definitions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds a new configuration option sseEndpoint to allow specifying the connection endpoint for the SSE server. The implementation is sound. I've provided one suggestion to improve code readability by using Optional for default value handling, which aligns with the existing style in the file.

Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…dpoint

This commit adds a new configuration option sseEndpoint to the SseServerParameters class, which is used to specify the exact endpoint for connecting to the SSE server. It also updates the related processing logic in DefaultMcpTransportBuilder to ensure the configuration is applied correctly.
@vorburger vorburger force-pushed the google_dev_mcp_sse_param branch from e47d78d to 83899b9 Compare August 18, 2025 14:21
@copybara-service copybara-service bot merged commit 30d63c0 into google:main Aug 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants