-
Notifications
You must be signed in to change notification settings - Fork 261
fix: Broken Dev UI (fixes #302) #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical issue where the Dev UI was not loading correctly due to improper packaging of its static assets. The fix involves a precise adjustment to the Maven build configuration, ensuring that the necessary web resources are correctly placed within the application's JAR file. This change directly resolves issue #302, making the Dev UI fully functional again.
Highlights
- Fix Broken Dev UI: Corrected the Maven resource packaging configuration in
dev/pom.xmlto ensure that thebrowserdirectory's contents are properly included in the final JAR artifact. This resolves an issue where the Dev UI was not functioning due to missing resources.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue with the Dev UI by changing how Maven packages the UI resources. The fix is effective. However, as noted in a comment within the pom.xml itself, a more idiomatic Maven approach would be to move the browser resources into the standard src/main/resources directory. I've added a review comment recommending this change, as it would simplify the build configuration and improve the project's long-term maintainability.
This will fix #302.
The currently broken Dev UI problem can be reproduced without this fix by running https://github.com/enola-dev/LearningADK#jitpack (which at
b80acebstill used the current ADK Java 417a8bc without this fix).Unfortunately it's more difficult than I thought to add non-regression integration test coverage for this; I was hoping to build upon #342 and #343 (which IMHO still add value as-is) with something like main...vorburger:adk-java:AdkWebServerTest-UI-packaging, but due to the way Maven works, that actually didn't reproduce the issue (so it's pointless).
But I've manually verified that this does the trick using https://github.com/enola-dev/LearningADK#snapshot.
@Poggecci @shukladivyansh merge?