fix: Make saveArtifact in CallbackContext synchronous
#495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
The return type of the artifactService is Single, meaning it doesn't get scheduled to execute until it is subscribed. Today it's not subscribed. This is a bug leads to saveArtifact never executes. Ideally the return type should be Rxjava instead of void, however since this is a open source library, changing return type is disruptive, the cl proposes to convert it as a blocking call, such that calling saveArtifact will be deterministically finished when it returns. PiperOrigin-RevId: 817930873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Make
saveArtifactinCallbackContextsynchronousThe return type of the artifactService is Single, meaning it doesn't get scheduled to execute until it is subscribed. Today it's not subscribed. This is a bug leads to saveArtifact never executes.
Ideally the return type should be Rxjava instead of void, however since this is a open source library, changing return type is disruptive, the cl proposes to convert it as a blocking call, such that calling saveArtifact will be deterministically finished when it returns.