refactor: PluginManager is used as a Plugin interface where possible #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_852964429
branch
7 times, most recently
from
97a59f4 to
299a1fb
Compare
InvocationContext -> PluginManager causes some interesting circular dependencies. Next step should probably be an interface for InvocationContext that can be used by Plugin. PiperOrigin-RevId: 853264745
copybara-service
bot
force-pushed
the
test_852964429
branch
from
299a1fb to
3d6d9de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: PluginManager is used as a Plugin interface where possible
InvocationContext -> PluginManager causes some interesting circular dependencies. Next step should probably be an interface for InvocationContext that can be used by Plugin.